refactor: refactor image link handling and add isImageLink function #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Simplify the image link handling by creating a separate function `isImageLink` - Replace the multiple `switch` statements with a single `if-else` statement in `GetAllFromURL`, `Crawler`, and `GetAllImageAddress` - Add `.jpg` extension to image links from `https://imgur.com` in `GetAllFromURL`, `Crawler`, and `GetAllImageAddress` - Remove the unused `foundImage` variable in `GetAllFromURL`, `Crawler`, and `GetAllImageAddress` - Add the `isImageLink` function to check if a given URL is an image link Signed-off-by: Evan Lin <evan.if.lin@linecorp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isImageLinkswitchstatements with a singleif-elsestatement inGetAllFromURL,Crawler, andGetAllImageAddress.jpgextension to image links fromhttps://imgur.cominGetAllFromURL,Crawler, andGetAllImageAddressfoundImagevariable inGetAllFromURL,Crawler, andGetAllImageAddressisImageLinkfunction to check if a given URL is an image link