download cmd handles playlist & video #178
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itscaro
changed the title
itscaro
force-pushed
the
download-playlist
branch
from
078c5de
to
c2d27ec
Compare
corny
approved these changes
Apr 30, 2021
| exitOnError(download(args[0])) | ||
| if playlistID, err := youtube.ExtractPlaylistID(args[0]); err != nil { | ||
| if videoID, err := youtube.ExtractVideoID(args[0]); err != nil { | ||
| exitOnError(errNotID) |
There was a problem hiding this comment.
Please try to keep the code more on the left. You don't need the else if you write instead:
videoID, err := youtube.ExtractVideoID(args[0])
if err != nil {
exitOnError(errNotID)
}There was a problem hiding this comment.
@corny modifed, could you have a look?
itscaro
force-pushed
the
download-playlist
branch
from
774e6d7
to
4cef99d
Compare
itscaro
force-pushed
the
download-playlist
branch
from
4cef99d
to
36cfe33
Compare
corny
force-pushed
the
master
branch
2 times, most recently
from
6ef3171
to
bc29310
Compare
|
Can you please finish merging this PR into the master? |
corny
approved these changes
May 29, 2023
corny
force-pushed
the
master
branch
2 times, most recently
from
4da7717
to
a22d61b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
download cmd now accepts a playlist ID/URL and downloads all media in the playlist.
Issues to fix
Please link issues this PR will fix:
#[issue number]
if no relevant issue, but this will fix something important for reference
, please free to open an issue.
Reminding
Something you can do before PR to reduce time to merge