VOS loss #47
Merged
VOS loss #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5e8332c.
kkirchheim
requested changes
Apr 9, 2024
src/pytorch_ood/detector/vos.py
Outdated
|
|
||
| def __init__(self, model: torch.nn.Module, weights_energy: torch.nn.Module): | ||
| """ | ||
| :param t: Temperature value :math:`T`. Default is 1. |
src/pytorch_ood/detector/vos.py
Outdated
| :param weights_energy: energy weights as torch.nn.module | ||
| """ | ||
| # Permutation depends on shape of logits | ||
| tmp_scores_ = logits.permute(0, 2, 3, 1) |
There was a problem hiding this comment.
will this only work in segmentation settings?
src/pytorch_ood/loss/vos.py
Outdated
| """ | ||
|
|
||
| def __init__( | ||
| self, logistic_regression, weights_energy, alpha=0.1, device="cuda:0", reduction="mean" |
There was a problem hiding this comment.
please add type hints to parameters
examples/segmentation/street_vos.py
Outdated
| # Create non-linear neural network functions | ||
| phi = torch.nn.Linear(1, 2) | ||
| weights_energy = torch.nn.Linear(num_classes, 1) | ||
| if 'cuda' in device: |
There was a problem hiding this comment.
please use to .to(device) method here as well
There was a problem hiding this comment.
also, these functions are linear
kkirchheim
added
documentation
kkirchheim
reviewed
Apr 9, 2024
| .vscode/settings.json | ||
| .pre-commit-config.yaml | ||
| .pre-commit-config.yaml | ||
| .gitignore |
There was a problem hiding this comment.
why are these files on the gitignore list?
kkirchheim
reviewed
Apr 11, 2024
src/pytorch_ood/loss/vos.py
Outdated
| input_for_lr = torch.cat((energy_x_in, energy_v_out), -1) | ||
| if "cuda" in self.device: | ||
| labels_for_lr = torch.cat( | ||
| (torch.ones(len(energy_x_in)).cuda(), torch.zeros(len(energy_v_out)).cuda()), -1 |
There was a problem hiding this comment.
please use .to(device) function
src/pytorch_ood/loss/vos.py
Outdated
| (torch.ones(len(energy_x_in)), torch.zeros(len(energy_v_out))), -1 | ||
| ) | ||
|
|
||
| criterion = torch.nn.CrossEntropyLoss(reduction=self.reduction) |
There was a problem hiding this comment.
please construct cross-entropy in constructor and not on each update
tests/detectors/test_vos.py
Outdated
|
|
||
| import torch | ||
|
|
||
| from src.pytorch_ood.detector import VOSBased |
There was a problem hiding this comment.
this should fail since detector was renamed
tests/loss/test_vos.py
Outdated
|
|
||
| class TestEnergyRegularization(unittest.TestCase): | ||
| """ | ||
| Test code for energy bounded learning |
kkirchheim
reviewed
Apr 12, 2024
src/pytorch_ood/detector/webo.py
Outdated
| """ | ||
| :param logits: logits given by your model | ||
| """ | ||
| return self.score(logits) |
There was a problem hiding this comment.
this will fail. please write some more tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add VOS loss, detector and segmentation example
pre-commit.config : update flake8 version to 5.0.2