add static fields to enum and error classes for discriminator, kind, and code fields #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeHowarth
reviewed
May 26, 2022
| @@ -457,6 +457,18 @@ function genEnum( | |||
| isExported: true, | |||
| name: variant.name, | |||
| properties: [ | |||
| { | |||
There was a problem hiding this comment.
It looks like this adds new static members instead of a replacing the instance variables - i.e. there are now both static and instance vars. Is this intentional?
There was a problem hiding this comment.
Yes, that's intentional. In typescript you cannot access static fields on an instance. So if we had only static fields you wouldn't be able to do foo.kind, only Foo.kind. So I have added both so we can do both.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #37