cleanup indexer transform function #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcoratger
reviewed
Jun 23, 2024
greged93
force-pushed
the
refactor-transform
branch
from
2fba4f0
to
9a78792
Compare
|
Hey @cwastche can you have a look at the failing tests? |
cwastche
force-pushed
the
refactor-transform
branch
from
de2ad92
to
51a902c
Compare
|
Fixed typing issues, tests seem to pass when ran locally |
eugypalu
reviewed
Jul 22, 2024
eugypalu
reviewed
Jul 22, 2024
anukkrit149
pushed a commit
to karnotxyz/kakarot-rpc
that referenced
this pull request
Aug 9, 2024
<!--- Please provide a general summary of your changes in the title above --> <!-- Give an estimate of the time you spent on this PR in terms of work days. Did you spend 0.5 days on this PR or rather 2 days? --> Time spent on this PR: ## Pull request type <!-- Please try to limit your pull request to one type, submit multiple pull requests if needed. --> Please check the type of change your PR introduces: - [ ] Bugfix - [ ] Feature - [ ] Code style update (formatting, renaming) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] Documentation content changes - [ ] Other (please describe): ## What is the current behavior? <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Resolves #<Issue number> ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - fixes an issue with messaging tests when kakarot was re-deployed, causing a mismatch between the l1messaging kakarot address and the actual one. We can simply remove this cache mechanism as re-deploying it for each test is not an issue. - - <!-- Reviewable:start --> - - - This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/kkrt-labs/kakarot/1226) <!-- Reviewable:end -->
eugypalu
force-pushed
the
refactor-transform
branch
from
a7809d8
to
dd8d98c
Compare
eugypalu
force-pushed
the
refactor-transform
branch
from
0162003
to
b1207ad
Compare
ClementWalter
approved these changes
Sep 16, 2024
eugypalu
force-pushed
the
refactor-transform
branch
2 times, most recently
from
52c4706
to
0eb7fbd
Compare
- Moved object mutations from map to forEach
- Add name constants for Collection - cleanup
eugypalu
force-pushed
the
refactor-transform
branch
from
0eb7fbd
to
f267c35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time spent on this PR: 2h30
Resolves: #1187
Pull Request type
What is the new behavior?
Does this introduce a breaking change?