-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: index pre-eip155 transactions #1363
feat: index pre-eip155 transactions #1363
Conversation
lgtm pending @greged93 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if we want to only index the white listed ones, that seems like a bit much what do you think @tcoratger? They shouldn't pass the rpc nor the execution layer so I think filtering a third time on the indexer is a lot
@greged93 I was thinking maybe in the past, on some specific transactions if we reindex everything from the beginning but I agree that it's a lot. As you can feel, both options are fine with me. |
9d9a4ea
to
42978f9
Compare
97d79f3
to
192a246
Compare
Resolves: #1362
Pull Request type
Please check the type of change your PR introduces:
What is the new behavior?
WHITE_LISTED_EIP_155_TRANSACTION_HASHES
.An error is no longer thrown for each transaction with v < 35, but due to this check in ethers, v must be equal to 27 or 28, otherwise
LegacyTransaction.fromTxData
will fail.https://github.com/ethereumjs/ethereumjs-monorepo/blob/fe0d6b4b0fb904f742c86ec47f4488a96f92b7af/packages/tx/src/legacy/tx.ts#L278
Does this introduce a breaking change?