Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mempool #1383

Merged
merged 4 commits into from
Sep 17, 2024
Merged

fix: mempool #1383

merged 4 commits into from
Sep 17, 2024

Conversation

greged93
Copy link
Collaborator

Time spent on this PR: 0.1 day

Resolves: #NA

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing

What is the new behavior?

Create a new EthDatabase for fetching database information for each transaction.

Does this introduce a breaking change?

  • Yes
  • No

greged93 and others added 2 commits September 16, 2024 15:43
<!--- Please provide a general summary of your changes in the title
above -->

<!-- Give an estimate of the time you spent on this PR in terms of work
days.
Did you spend 0.5 days on this PR or rather 2 days?  -->

Time spent on this PR: 0.3d

## Pull request type

<!-- Please try to limit your pull request to one type,
submit multiple pull requests if needed. -->

Please check the type of change your PR introduces:

- [ ] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, renaming)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] Documentation content changes
- [ ] Other (please describe):

## What is the current behavior?

<!-- Please describe the current behavior that you are modifying,
or link to a relevant issue. -->

Resolves #<Issue number>

## What is the new behavior?

<!-- Please describe the behavior or changes that are being added by
this PR. -->

- Bumps dependencies, required to use the latest types in the cairo core
lib.
- Bumping starknet-py requires bumping Katana to v1.0, which supports
the latest rpc spec 0.7.1
- Instead of relying on a "hardcoded" erc20 json abi, add the contract
to the list of contracts to compile

<!-- Reviewable:start -->
- - -
This change is [<img src="https://reviewable.io/review_button.svg"
height="34" align="absmiddle"
alt="Reviewable"/>](https://reviewable.io/reviews/kkrt-labs/kakarot/1269)
<!-- Reviewable:end -->

---------

Co-authored-by: Clément Walter <clement0walter@gmail.com>
src/pool/validate.rs Outdated Show resolved Hide resolved
@greged93 greged93 merged commit 08bca4c into kkrt-labs:main Sep 17, 2024
4 checks passed
@greged93 greged93 deleted the fix/mempool branch September 17, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants