Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update starknet address computation method #860

Closed
enitrat opened this issue Aug 22, 2024 · 0 comments · Fixed by #862
Closed

feat: update starknet address computation method #860

enitrat opened this issue Aug 22, 2024 · 0 comments · Fixed by #862
Assignees
@enitrat
Labels
enhancement New feature or request

Comments

@enitrat
Copy link
Collaborator

enitrat commented Aug 22, 2024

Feature Request

Update the starknet address computation method (and also deployment parameters of contracts to):

  • salt = evm_address
  • calldata = [1, evm_address]
  • calldata_len = 2
  • deploy_from_zero = FALSE

reference: https://github.com/kkrt-labs/kakarot/blob/65e333a0d3475e81b0a6367b0f00561c763da0a0/src/backend/starknet.cairo#L65-L84

ef-tests: https://github.com/kkrt-labs/ef-tests/blob/62d18a83dcefc9c32529f1bbe63ec7d1f8ea0ba5/crates/ef-testing/src/evm_sequencer/sequencer/mod.rs#L157-L166
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@enitrat enitrat

Labels
enhancement New feature or request
Projects
Kakarot's Project Management
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: update starknet address computation method kkrt-labs/kakarot-ssj
1 participant
@enitrat