Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update starknet address computation method #862

Merged
merged 3 commits into from
Aug 22, 2024
Merged

feat: update starknet address computation method #862

merged 3 commits into from
Aug 22, 2024

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Aug 22, 2024 •
edited
Loading

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves: #860
resolves #863

What is the new behavior?

  • Address computation no longer takes kakarot_address as constructor argument, (now [1, evm_address]) and is DEPLOY_FROM_ZERO is now false, so that the deployer;s address (kakarot's) is used for computation of the address of the deployed contract

Does this introduce a breaking change?

  • Yes
  • No

This change is Reviewable

@enitrat enitrat mentioned this pull request Aug 22, 2024
Closed
@enitrat enitrat merged commit 14d6036 into main Aug 22, 2024
4 checks passed
@enitrat enitrat deleted the feat/update-address-computation branch August 22, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClementWalter ClementWalter Awaiting requested review from ClementWalter ClementWalter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: update uninitialized_account constructor feat: update starknet address computation method
1 participant
@enitrat