Skip to content

Commit

Permalink
feat: disable modexp (#1429)
Browse files Browse the repository at this point in the history
<!--- Please provide a general summary of your changes in the title
above -->

<!-- Give an estimate of the time you spent on this PR in terms of work
days.
Did you spend 0.5 days on this PR or rather 2 days?  -->

Time spent on this PR:

## Pull request type

<!-- Please try to limit your pull request to one type,
submit multiple pull requests if needed. -->

Please check the type of change your PR introduces:

- [ ] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, renaming)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] Documentation content changes
- [ ] Other (please describe):

## What is the current behavior?

<!-- Please describe the current behavior that you are modifying,
or link to a relevant issue. -->

Resolves #1422

## What is the new behavior?

<!-- Please describe the behavior or changes that are being added by
this PR. -->

- Disables the external call to the cairo1 class for modexp operations
- Removes the legacy modexp files.
-

<!-- Reviewable:start -->
- - -
This change is [<img src="https://reviewable.io/review_button.svg"
height="34" align="absmiddle"
alt="Reviewable"/>](https://reviewable.io/reviews/kkrt-labs/kakarot/1429)
<!-- Reviewable:end -->
  • Loading branch information
enitrat committed Sep 20, 2024
1 parent 221b976 commit c7896d0
Show file tree
Hide file tree
Showing 6 changed files with 273 additions and 461 deletions.
272 changes: 272 additions & 0 deletions blockchain-tests-skip.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ testname:
- create2collisionStorageParis_d0g0v0_Cancun
- create2collisionStorageParis_d1g0v0_Cancun
- create2collisionStorageParis_d2g0v0_Cancun
- create2callPrecompiles_d4g0v0_Cancun
stCallCreateCallCodeTest:
- Call1024PreCalls_d0g0v0_Cancun #RunResources error
- Call1024PreCalls_d0g1v0_Cancun #RunResources error
Expand All @@ -113,6 +114,23 @@ testname:
stEIP150singleCodeGasPrices:
- gasCostExp_d7g0v0_Cancun #RunResources error
stPreCompiledContracts2:
- modexpRandomInput_d0g0v0_Cancun
- modexpRandomInput_d0g1v0_Cancun
- modexp_0_0_0_20500_d0g1v0_Cancun
- modexp_0_0_0_20500_d0g2v0_Cancun
- modexp_0_0_0_20500_d0g3v0_Cancun
- modexp_0_0_0_22000_d0g0v0_Cancun
- modexp_0_0_0_22000_d0g1v0_Cancun
- modexp_0_0_0_22000_d0g2v0_Cancun
- modexp_0_0_0_22000_d0g3v0_Cancun
- modexp_0_0_0_25000_d0g0v0_Cancun
- modexp_0_0_0_25000_d0g1v0_Cancun
- modexp_0_0_0_25000_d0g2v0_Cancun
- modexp_0_0_0_25000_d0g3v0_Cancun
- modexp_0_0_0_35000_d0g0v0_Cancun
- modexp_0_0_0_35000_d0g1v0_Cancun
- modexp_0_0_0_35000_d0g2v0_Cancun
- modexp_0_0_0_35000_d0g3v0_Cancun
- CALLBlake2f_d9g0v0_Cancun #RunResources error
- CALLBlake2f_d9g1v0_Cancun #RunResources error
- CALLBlake2f_d9g2v0_Cancun #RunResources error
Expand Down Expand Up @@ -149,6 +167,247 @@ testname:
- modexpRandomInput_d2g0v0_Cancun #RunResources error
- modexpRandomInput_d2g1v0_Cancun #RunResources error
stPreCompiledContracts:
- modexpTests_d0g0v0_Cancun
- modexpTests_d100g0v0_Cancun
- modexpTests_d101g0v0_Cancun
- modexpTests_d102g0v0_Cancun
- modexpTests_d103g0v0_Cancun
- modexpTests_d104g0v0_Cancun
- modexpTests_d105g0v0_Cancun
- modexpTests_d106g0v0_Cancun
- modexpTests_d107g0v0_Cancun
- modexpTests_d108g0v0_Cancun
- modexpTests_d109g0v0_Cancun
- modexpTests_d10g0v0_Cancun
- modexpTests_d110g0v0_Cancun
- modexpTests_d111g0v0_Cancun
- modexpTests_d112g0v0_Cancun
- modexpTests_d113g0v0_Cancun
- modexpTests_d114g0v0_Cancun
- modexpTests_d115g0v0_Cancun
- modexpTests_d116g0v0_Cancun
- modexpTests_d117g0v0_Cancun
- modexpTests_d118g0v0_Cancun
- modexpTests_d119g0v0_Cancun
- modexpTests_d11g0v0_Cancun
- modexpTests_d120g0v0_Cancun
- modexpTests_d121g0v0_Cancun
- modexpTests_d122g0v0_Cancun
- modexpTests_d123g0v0_Cancun
- modexpTests_d124g0v0_Cancun
- modexpTests_d125g0v0_Cancun
- modexpTests_d126g0v0_Cancun
- modexpTests_d12g0v0_Cancun
- modexpTests_d13g0v0_Cancun
- modexpTests_d14g0v0_Cancun
- modexpTests_d15g0v0_Cancun
- modexpTests_d16g0v0_Cancun
- modexpTests_d17g0v0_Cancun
- modexpTests_d18g0v0_Cancun
- modexpTests_d19g0v0_Cancun
- modexpTests_d1g0v0_Cancun
- modexpTests_d20g0v0_Cancun
- modexpTests_d21g0v0_Cancun
- modexpTests_d22g0v0_Cancun
- modexpTests_d23g0v0_Cancun
- modexpTests_d24g0v0_Cancun
- modexpTests_d25g0v0_Cancun
- modexpTests_d26g0v0_Cancun
- modexpTests_d27g0v0_Cancun
- modexpTests_d28g0v0_Cancun
- modexpTests_d29g0v0_Cancun
- modexpTests_d2g0v0_Cancun
- modexpTests_d30g0v0_Cancun
- modexpTests_d31g0v0_Cancun
- modexpTests_d32g0v0_Cancun
- modexpTests_d33g0v0_Cancun
- modexpTests_d34g0v0_Cancun
- modexpTests_d35g0v0_Cancun
- modexpTests_d36g0v0_Cancun
- modexpTests_d37g0v0_Cancun
- modexpTests_d38g0v0_Cancun
- modexpTests_d39g0v0_Cancun
- modexpTests_d3g0v0_Cancun
- modexpTests_d40g0v0_Cancun
- modexpTests_d41g0v0_Cancun
- modexpTests_d42g0v0_Cancun
- modexpTests_d43g0v0_Cancun
- modexpTests_d44g0v0_Cancun
- modexpTests_d45g0v0_Cancun
- modexpTests_d46g0v0_Cancun
- modexpTests_d47g0v0_Cancun
- modexpTests_d48g0v0_Cancun
- modexpTests_d49g0v0_Cancun
- modexpTests_d4g0v0_Cancun
- modexpTests_d50g0v0_Cancun
- modexpTests_d51g0v0_Cancun
- modexpTests_d52g0v0_Cancun
- modexpTests_d53g0v0_Cancun
- modexpTests_d54g0v0_Cancun
- modexpTests_d55g0v0_Cancun
- modexpTests_d56g0v0_Cancun
- modexpTests_d57g0v0_Cancun
- modexpTests_d58g0v0_Cancun
- modexpTests_d59g0v0_Cancun
- modexpTests_d5g0v0_Cancun
- modexpTests_d60g0v0_Cancun
- modexpTests_d61g0v0_Cancun
- modexpTests_d62g0v0_Cancun
- modexpTests_d63g0v0_Cancun
- modexpTests_d64g0v0_Cancun
- modexpTests_d65g0v0_Cancun
- modexpTests_d66g0v0_Cancun
- modexpTests_d67g0v0_Cancun
- modexpTests_d68g0v0_Cancun
- modexpTests_d69g0v0_Cancun
- modexpTests_d6g0v0_Cancun
- modexpTests_d70g0v0_Cancun
- modexpTests_d71g0v0_Cancun
- modexpTests_d72g0v0_Cancun
- modexpTests_d73g0v0_Cancun
- modexpTests_d74g0v0_Cancun
- modexpTests_d75g0v0_Cancun
- modexpTests_d76g0v0_Cancun
- modexpTests_d77g0v0_Cancun
- modexpTests_d78g0v0_Cancun
- modexpTests_d79g0v0_Cancun
- modexpTests_d7g0v0_Cancun
- modexpTests_d80g0v0_Cancun
- modexpTests_d81g0v0_Cancun
- modexpTests_d82g0v0_Cancun
- modexpTests_d83g0v0_Cancun
- modexpTests_d84g0v0_Cancun
- modexpTests_d85g0v0_Cancun
- modexpTests_d86g0v0_Cancun
- modexpTests_d87g0v0_Cancun
- modexpTests_d88g0v0_Cancun
- modexpTests_d89g0v0_Cancun
- modexpTests_d8g0v0_Cancun
- modexpTests_d90g0v0_Cancun
- modexpTests_d91g0v0_Cancun
- modexpTests_d92g0v0_Cancun
- modexpTests_d93g0v0_Cancun
- modexpTests_d94g0v0_Cancun
- modexpTests_d95g0v0_Cancun
- modexpTests_d96g0v0_Cancun
- modexpTests_d97g0v0_Cancun
- modexpTests_d98g0v0_Cancun
- modexpTests_d99g0v0_Cancun
- modexpTests_d9g0v0_Cancun
- modexp_d0g0v0_Cancun
- modexp_d0g1v0_Cancun
- modexp_d0g2v0_Cancun
- modexp_d0g3v0_Cancun
- modexp_d10g0v0_Cancun
- modexp_d10g1v0_Cancun
- modexp_d10g2v0_Cancun
- modexp_d10g3v0_Cancun
- modexp_d12g0v0_Cancun
- modexp_d12g1v0_Cancun
- modexp_d12g2v0_Cancun
- modexp_d12g3v0_Cancun
- modexp_d13g0v0_Cancun
- modexp_d13g1v0_Cancun
- modexp_d13g2v0_Cancun
- modexp_d13g3v0_Cancun
- modexp_d15g0v0_Cancun
- modexp_d15g1v0_Cancun
- modexp_d15g2v0_Cancun
- modexp_d15g3v0_Cancun
- modexp_d18g0v0_Cancun
- modexp_d18g1v0_Cancun
- modexp_d18g2v0_Cancun
- modexp_d18g3v0_Cancun
- modexp_d19g0v0_Cancun
- modexp_d19g1v0_Cancun
- modexp_d19g2v0_Cancun
- modexp_d19g3v0_Cancun
- modexp_d1g0v0_Cancun
- modexp_d1g1v0_Cancun
- modexp_d1g2v0_Cancun
- modexp_d1g3v0_Cancun
- modexp_d20g0v0_Cancun
- modexp_d20g1v0_Cancun
- modexp_d20g2v0_Cancun
- modexp_d20g3v0_Cancun
- modexp_d21g0v0_Cancun
- modexp_d21g1v0_Cancun
- modexp_d21g2v0_Cancun
- modexp_d21g3v0_Cancun
- modexp_d22g0v0_Cancun
- modexp_d22g1v0_Cancun
- modexp_d22g2v0_Cancun
- modexp_d22g3v0_Cancun
- modexp_d23g0v0_Cancun
- modexp_d23g1v0_Cancun
- modexp_d23g2v0_Cancun
- modexp_d23g3v0_Cancun
- modexp_d24g0v0_Cancun
- modexp_d24g1v0_Cancun
- modexp_d24g2v0_Cancun
- modexp_d24g3v0_Cancun
- modexp_d31g0v0_Cancun
- modexp_d31g1v0_Cancun
- modexp_d31g2v0_Cancun
- modexp_d31g3v0_Cancun
- modexp_d32g0v0_Cancun
- modexp_d32g1v0_Cancun
- modexp_d32g2v0_Cancun
- modexp_d32g3v0_Cancun
- modexp_d34g0v0_Cancun
- modexp_d34g1v0_Cancun
- modexp_d34g2v0_Cancun
- modexp_d34g3v0_Cancun
- modexp_d35g0v0_Cancun
- modexp_d35g1v0_Cancun
- modexp_d35g2v0_Cancun
- modexp_d35g3v0_Cancun
- modexp_d3g0v0_Cancun
- modexp_d3g1v0_Cancun
- modexp_d3g2v0_Cancun
- modexp_d3g3v0_Cancun
- modexp_d4g0v0_Cancun
- modexp_d4g1v0_Cancun
- modexp_d4g2v0_Cancun
- modexp_d4g3v0_Cancun
- modexp_d5g0v0_Cancun
- modexp_d5g1v0_Cancun
- modexp_d5g2v0_Cancun
- modexp_d5g3v0_Cancun
- modexp_d6g0v0_Cancun
- modexp_d6g1v0_Cancun
- modexp_d6g2v0_Cancun
- modexp_d6g3v0_Cancun
- modexp_d7g0v0_Cancun
- modexp_d7g1v0_Cancun
- modexp_d7g2v0_Cancun
- modexp_d7g3v0_Cancun
- modexp_d8g0v0_Cancun
- modexp_d8g1v0_Cancun
- modexp_d8g2v0_Cancun
- modexp_d8g3v0_Cancun
- modexp_d9g0v0_Cancun
- modexp_d9g1v0_Cancun
- modexp_d9g2v0_Cancun
- modexp_d9g3v0_Cancun
- precompsEIP2929Cancun_d112g0v0_Cancun
- precompsEIP2929Cancun_d130g0v0_Cancun
- precompsEIP2929Cancun_d148g0v0_Cancun
- precompsEIP2929Cancun_d166g0v0_Cancun
- precompsEIP2929Cancun_d184g0v0_Cancun
- precompsEIP2929Cancun_d202g0v0_Cancun
- precompsEIP2929Cancun_d220g0v0_Cancun
- precompsEIP2929Cancun_d22g0v0_Cancun
- precompsEIP2929Cancun_d238g0v0_Cancun
- precompsEIP2929Cancun_d256g0v0_Cancun
- precompsEIP2929Cancun_d274g0v0_Cancun
- precompsEIP2929Cancun_d292g0v0_Cancun
- precompsEIP2929Cancun_d310g0v0_Cancun
- precompsEIP2929Cancun_d40g0v0_Cancun
- precompsEIP2929Cancun_d58g0v0_Cancun
- precompsEIP2929Cancun_d76g0v0_Cancun
- precompsEIP2929Cancun_d7g0v0_Cancun
- precompsEIP2929Cancun_d94g0v0_Cancun
- idPrecomps_d4g0v0_Cancun
- idPrecomps_d9g0v0_Cancun
- modexp_d11g0v0_Cancun
Expand Down Expand Up @@ -323,6 +582,14 @@ testname:
- randomStatetest64_d0g0v0_Cancun
- randomStatetest85_d0g0v0_Cancun
stRevertTest:
- RevertPrecompiledTouchExactOOG_Paris_d12g1v0_Cancun
- RevertPrecompiledTouchExactOOG_Paris_d12g2v0_Cancun
- RevertPrecompiledTouchExactOOG_Paris_d20g1v0_Cancun
- RevertPrecompiledTouchExactOOG_Paris_d20g2v0_Cancun
- RevertPrecompiledTouchExactOOG_Paris_d28g1v0_Cancun
- RevertPrecompiledTouchExactOOG_Paris_d28g2v0_Cancun
- RevertPrecompiledTouchExactOOG_Paris_d4g1v0_Cancun
- RevertPrecompiledTouchExactOOG_Paris_d4g2v0_Cancun
- RevertInCreateInInit_Paris_d0g0v0_Cancun
- RevertPrecompiledTouchExactOOG_Paris_d13g1v0_Cancun
- RevertPrecompiledTouchExactOOG_Paris_d13g2v0_Cancun
Expand Down Expand Up @@ -350,8 +617,13 @@ testname:
- InitCollisionParis_d2g0v0_Cancun
- InitCollisionParis_d3g0v0_Cancun
stReturnDataTest:
- modexp_modsize0_returndatasize_d0g0v0_Cancun
- modexp_modsize0_returndatasize_d1g0v0_Cancun
- modexp_modsize0_returndatasize_d2g0v0_Cancun
- modexp_modsize0_returndatasize_d3g0v0_Cancun
- modexp_modsize0_returndatasize_d4g0v0_Cancun #RunResources error
stStaticCall:
- static_CallEcrecover0_0input_d5g0v0_Cancun
- StaticcallToPrecompileFromCalledContract_d0g0v0_Cancun
- StaticcallToPrecompileFromContractInitialization_d0g0v0_Cancun
- StaticcallToPrecompileFromTransaction_d0g0v0_Cancun
Expand Down
61 changes: 0 additions & 61 deletions src/kakarot/precompiles/modexp.cairo

This file was deleted.

2 changes: 1 addition & 1 deletion src/kakarot/precompiles/precompiles.cairo
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ namespace Precompiles {
ret;
call PrecompileDataCopy.run; // 0x4
ret;
call external_precompile; // 0x5
call not_implemented_precompile; // 0x5
ret;
call not_implemented_precompile; // 0x6
ret;
Expand Down
Loading

0 comments on commit c7896d0

Please sign in to comment.