Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: constants updates for sn mainnet #1370

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

ClementWalter
Copy link
Member

@ClementWalter ClementWalter commented Sep 2, 2024

This change is Reviewable

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.42%. Comparing base (f1e7ebb) to head (3a397f3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1370      +/-   ##
==========================================
- Coverage   63.54%   63.42%   -0.13%     
==========================================
  Files          52       52              
  Lines        8970     8970              
==========================================
- Hits         5700     5689      -11     
- Misses       3270     3281      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@obatirou
Copy link
Collaborator

obatirou commented Sep 2, 2024

End to end tests are failing
Also realizing it failed on main for test_safe.py.

Maybe related to async fixtures like last time if not mistaken ?

After a look some fixture scoping are missing:

  • test_cairo_precompiles.py: cairo_counter_caller and cairo_counter should have a scope module
  • test_dual_vm_token.py: starknet_token and dual_vm_token should have a scope module
  • test_pragma_precompiles.py: cairo_pragma should have a scope function

From my understanding, this function should not be marked async as get_contract is not

@pytest_asyncio.fixture(scope="session")
async def cairo_counter(deployer) -> Contract:
    """
    Return a cached version of the cairo_counter contract.
    """
    return await get_contract("Counter", provider=deployer)

Did not succeed in reproducing the error in local for now

@ClementWalter ClementWalter merged commit b2f8e18 into kkrt-labs:main Sep 3, 2024
5 of 6 checks passed
@ClementWalter ClementWalter deleted the cw/improve-chainid-log branch September 3, 2024 16:18
@ClementWalter ClementWalter changed the title Minor fixes for sn mainnet dev: constants updates for sn mainnet Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants