Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cairo precompile revert for child contexts #1378

Merged

Conversation

obatirou
Copy link
Collaborator

@obatirou obatirou commented Sep 3, 2024

Time spent on this PR:

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves #1377

What is the new behavior?

  • Revert cairo tx when evm revert
  • cairo_precompile_called ORed when propagated to parent

This change is Reviewable

@obatirou obatirou force-pushed the child-context-revert-precompiles branch from 61b4ff3 to de6fc38 Compare September 3, 2024 10:25
@obatirou obatirou marked this pull request as ready for review September 3, 2024 10:26
@ClementWalter ClementWalter merged commit e9b3f95 into kkrt-labs:main Sep 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: revert SN tx whenever there has been a cairo precompile and EVM context reverts
2 participants