Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parsing invalid addresses panics #1384

Merged
merged 4 commits into from
Sep 4, 2024

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Sep 4, 2024

Time spent on this PR:

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves #1375

What is the new behavior?


This change is Reviewable

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.60%. Comparing base (f1e7ebb) to head (9f81ccf).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1384      +/-   ##
==========================================
+ Coverage   63.54%   63.60%   +0.05%     
==========================================
  Files          52       52              
  Lines        8970     8979       +9     
==========================================
+ Hits         5700     5711      +11     
+ Misses       3270     3268       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClementWalter ClementWalter merged commit dbc9bc6 into main Sep 4, 2024
9 checks passed
@ClementWalter ClementWalter deleted the fix/parsing-invalid-addresses branch September 4, 2024 09:45
matthieuauger pushed a commit to matthieuauger/kakarot that referenced this pull request Nov 9, 2024
improve the DatabaseRef implementation for EthDatabase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: try_parse_destination_from_bytes returns None if the address is invalid
2 participants