Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install scarb in release yml #1401

Merged
merged 1 commit into from
Sep 9, 2024
Merged

fix: install scarb in release yml #1401

merged 1 commit into from
Sep 9, 2024

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Sep 9, 2024

Time spent on this PR:

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves #

What is the new behavior?

  • Installs scarb in the release workflow, required in make build

This change is Reviewable

@enitrat enitrat merged commit 4b2139d into main Sep 9, 2024
5 checks passed
@enitrat enitrat deleted the fix/release.yml branch September 9, 2024 12:53
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.19%. Comparing base (ae5843a) to head (223c946).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1401      +/-   ##
==========================================
+ Coverage   64.13%   64.19%   +0.05%     
==========================================
  Files          52       52              
  Lines        9060     9060              
==========================================
+ Hits         5811     5816       +5     
+ Misses       3249     3244       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

matthieuauger pushed a commit to matthieuauger/kakarot that referenced this pull request Nov 9, 2024
…sh` (kkrt-labs#1401)

* reactivate test_transaction_by_hash and upstream transaction_by_hash

* clean up

* fix nightly

* fix

* fix clippy

* add random tx to the test

* clean up

* Update rust-toolchain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants