-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dualVMToken starknet functions #1421
feat: dualVMToken starknet functions #1421
Conversation
3b8f725
to
0ef7eb3
Compare
So tl;dr after irl comments
Relevant utils may include |
@obatirou see so we can add functions to the dict and access them easily in the test |
b5cc83b
to
aa1edf9
Compare
aa1edf9
to
72f7973
Compare
about DEFAULT_PRIME : you test that you give an invalid starknet address, ie an address greater or equal than DEFAULT_PRIME. You could parametrize over [DEFAULT_PRIME, 2**256), but if it's only one value, I think that DEFAULT_PRIME makes it more explicit |
Time spent on this PR:
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Resolves #1417
What is the new behavior?
This change is