Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: use consts for empty hash #1431

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

dev: use consts for empty hash #1431

wants to merge 2 commits into from

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Sep 20, 2024

Time spent on this PR:

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves #1410

What is the new behavior?


This change is Reviewable

@enitrat enitrat changed the title Dev/empty hash const dev: use consts for empty hash Sep 20, 2024
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.0%. Comparing base (c7896d0) to head (3bf2671).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1431   +/-   ##
=====================================
  Coverage   63.0%   63.0%           
=====================================
  Files         49      49           
  Lines       8332    8332           
=====================================
  Hits        5252    5252           
  Misses      3080    3080           
Flag Coverage Δ
63.0% <100.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev: use constants for empty code hash
1 participant