Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apply body #769

Merged
merged 28 commits into from
Feb 13, 2025
Merged

feat: apply body #769

merged 28 commits into from
Feb 13, 2025

Conversation

Eikix
Copy link
Member

@Eikix Eikix commented Feb 12, 2025

closes #559

@Eikix Eikix force-pushed the feat/apply_body_test branch 2 times, most recently from 0eab07d to 0b34a44 Compare February 12, 2025 10:33
@ClementWalter ClementWalter changed the title Feat/apply body test feat: apply body Feb 12, 2025
@Eikix Eikix force-pushed the feat/apply_body_test branch 4 times, most recently from 8d2ade1 to 2ed71a2 Compare February 12, 2025 13:01
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 99.63235% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.68%. Comparing base (a392270) to head (9783a24).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
cairo/ethereum/cancun/fork.cairo 99.60% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #769      +/-   ##
==========================================
+ Coverage   81.60%   82.68%   +1.07%     
==========================================
  Files          56       56              
  Lines       12870    13138     +268     
==========================================
+ Hits        10503    10863     +360     
+ Misses       2367     2275      -92     
Flag Coverage Δ
ci 82.68% <99.63%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Eikix Eikix force-pushed the feat/apply_body_test branch 2 times, most recently from b9206e1 to a4243dd Compare February 12, 2025 14:55
@Eikix Eikix force-pushed the feat/apply_body_test branch 3 times, most recently from e9f4eb8 to 7fceb6f Compare February 13, 2025 07:27
@Eikix
Copy link
Member Author

Eikix commented Feb 13, 2025

UPDATE: rebased on #788 to have tests be able to pass, careful not to merge this PR if #788 isn't approved

@Eikix Eikix changed the base branch from main to tmp/fix-preimages-issues February 13, 2025 07:44
@Eikix Eikix marked this pull request as draft February 13, 2025 07:44
@obatirou obatirou marked this pull request as ready for review February 13, 2025 10:54
obatirou
obatirou previously approved these changes Feb 13, 2025
Copy link
Collaborator

@enitrat enitrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to be merged to main

@Eikix Eikix force-pushed the feat/apply_body_test branch from 4873f15 to 9783a24 Compare February 13, 2025 16:16
@Eikix
Copy link
Member Author

Eikix commented Feb 13, 2025

needs to be merged to main

rebased

@enitrat enitrat merged commit dd3756d into main Feb 13, 2025
11 checks passed
@enitrat enitrat deleted the feat/apply_body_test branch February 13, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

apply_body (skip computations and asserts of state roots for now)
3 participants