Add map type schema store #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't encode the empty map as an JSON array
prior to this change, the type is copied to each alias making the term bloated. changed to store alias as 'index', meaning when look up, it needs to first resolve the type full-name and then look up again.
Feat add map store
|
|
|
LGTM |
mikpe
approved these changes
Feb 29, 2024
|
Tagged 2.10.0 |
|
I get a dialyzer error when integrating this and building with OTP-25. FYI @zmstone |
|
Fix in #124 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This HEAD is tagged as
2.10.0in emqx fork