Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Define custom multiple default theme options using an Array #13

Merged
merged 1 commit into from
Jul 12, 2017

Conversation

Smarina
Copy link
Contributor

@Smarina Smarina commented Jul 12, 2017

I wanted to get a random pokemon chosen between a few that I like, so I thought about this little enhancement.
This way you can set the "pokemon" option in hyper config to something like
pokemon: ['mewtwo', 'zapdos', 'moltres', 'articuno', 'pikachu', 'raichu', 'charizard', 'mew']
or even
pokemon: ['pikachu', 'random']
for a 50% of getting a pikachu.

What do you think?

@klaudiosinani
Copy link
Owner

Hi @Smarina! Your idea is so awesome! It can be combined perfectly with the upcoming theme options and features 😄 Thank you tons for taking the time to contribute 🎉 Can't wait to ship it everyone 😄
You are more than welcome to add anything new you might have in mind : )

@klaudiosinani klaudiosinani changed the title Set the pokemon-theme to an Array containing multiple default options Feature: Define custom multiple default theme options using an Array Jul 12, 2017
@klaudiosinani klaudiosinani merged commit b9c5fb6 into klaudiosinani:master Jul 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants