s2: Avoid Decode size checks #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add another decode loop that doesn't check sizes as long as src is big enough. For now only in Go version. Streams: ``` Before: Decompressing. 426243297 -> 1000000000 [234.61%]; 1.941s, 491.3MB/s After: Decompressing. 426243297 -> 1000000000 [234.61%]; 1.895s, 503.3MB/s ``` Some blocks like it a lot: ``` BenchmarkDecodeS2Block/4-pdf/block-32 379 336 -11.35% BenchmarkDecodeS2Block/4-pdf/block-better-32 691 630 -8.83% BenchmarkDecodeS2Block/4-pdf/block-best-32 816 702 -13.97% BenchmarkDecodeS2Block/5-html4/block-32 13645 8727 -36.04% BenchmarkDecodeS2Block/5-html4/block-better-32 14059 9204 -34.53% BenchmarkDecodeS2Block/5-html4/block-best-32 13729 8975 -34.63% ```
This was referenced Mar 8, 2021
klauspost
added a commit
to klauspost/minio
that referenced
this pull request
Mar 10, 2021
Relevant updates: * Less allocations on decode: klauspost/compress#322 * Fixed rare out-of-bounds write on amd64. * ARM64 decompression assembly. Around 2x output speed. klauspost/compress#324 * Speed up decompression on non-assembly platforms. klauspost/compress#328 Upgrade cpuid to match simdjson.
1 task
harshavardhana
pushed a commit
to minio/minio
that referenced
this pull request
Mar 10, 2021
Relevant updates: * Less allocations on decode: klauspost/compress#322 * Fixed rare out-of-bounds write on amd64. * ARM64 decompression assembly. Around 2x output speed. klauspost/compress#324 * Speed up decompression on non-assembly platforms. klauspost/compress#328 Upgrade cpuid to match simdjson.
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add another decode loop that doesn't check sizes as long as src is big enough.
For now only in Go version.
Streams:
Some blocks like it a lot: