huff0: Use buffers for 1X decodes #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also make buffers safe from concurrent decoder use. ``` benchmark old ns/op new ns/op delta BenchmarkDecompress1XTable/digits-32 256367 262489 +2.39% BenchmarkDecompress1XTable/gettysburg-32 5189 5224 +0.67% BenchmarkDecompress1XTable/twain-32 825950 825534 -0.05% BenchmarkDecompress1XTable/low-ent.10k-32 88050 88429 +0.43% BenchmarkDecompress1XTable/superlow-ent-10k-32 23420 23456 +0.15% BenchmarkDecompress1XTable/crash2-32 687 676 -1.59% BenchmarkDecompress1XTable/endzerobits-32 80.9 78.4 -3.07% BenchmarkDecompress1XTable/endnonzero-32 494 511 +3.40% BenchmarkDecompress1XTable/case1-32 1948 1924 -1.23% BenchmarkDecompress1XTable/case2-32 1916 1886 -1.57% BenchmarkDecompress1XTable/case3-32 1945 1921 -1.23% BenchmarkDecompress1XTable/pngdata.001-32 126909 125848 -0.84% BenchmarkDecompress1XTable/normcount2-32 1285 1295 +0.78% BenchmarkDecompress1XNoTable/digits-32 255503 261690 +2.42% BenchmarkDecompress1XNoTable/gettysburg-32 4029 4014 -0.37% BenchmarkDecompress1XNoTable/twain-32 823710 821251 -0.30% BenchmarkDecompress1XNoTable/low-ent.10k-32 87024 87182 +0.18% BenchmarkDecompress1XNoTable/superlow-ent-10k-32 22812 23353 +2.37% BenchmarkDecompress1XNoTable/crash2-32 82.6 67.2 -18.62% BenchmarkDecompress1XNoTable/endzerobits-32 54.3 43.8 -19.47% BenchmarkDecompress1XNoTable/endnonzero-32 59.6 46.6 -21.86% BenchmarkDecompress1XNoTable/case1-32 179 159 -11.23% BenchmarkDecompress1XNoTable/case2-32 144 128 -10.71% BenchmarkDecompress1XNoTable/case3-32 165 145 -12.29% BenchmarkDecompress1XNoTable/pngdata.001-32 123734 123297 -0.35% BenchmarkDecompress1XNoTable/normcount2-32 248 241 -3.14% BenchmarkDecompress4XNoTable/digits-32 152812 151641 -0.77% BenchmarkDecompress4XNoTable/gettysburg-32 2585 2712 +4.91% BenchmarkDecompress4XNoTable/twain-32 529935 550282 +3.84% BenchmarkDecompress4XNoTable/low-ent.10k-32 53602 52664 -1.75% BenchmarkDecompress4XNoTable/superlow-ent-10k-32 14375 14054 -2.23% BenchmarkDecompress4XNoTable/case1-32 254 226 -10.84% BenchmarkDecompress4XNoTable/case2-32 207 182 -12.22% BenchmarkDecompress4XNoTable/case3-32 215 186 -13.14% BenchmarkDecompress4XNoTable/pngdata.001-32 73031 76067 +4.16% BenchmarkDecompress4XNoTable/normcount2-32 309 280 -9.38% BenchmarkDecompress4XNoTableTableLog8/digits-32 152307 150121 -1.44% BenchmarkDecompress4XTable/digits-32 152793 150602 -1.43% BenchmarkDecompress4XTable/gettysburg-32 3861 3924 +1.63% BenchmarkDecompress4XTable/twain-32 536438 550964 +2.71% BenchmarkDecompress4XTable/low-ent.10k-32 54465 53176 -2.37% BenchmarkDecompress4XTable/superlow-ent-10k-32 14904 14677 -1.52% BenchmarkDecompress4XTable/case1-32 2000 2007 +0.35% BenchmarkDecompress4XTable/case2-32 1982 1968 -0.71% BenchmarkDecompress4XTable/case3-32 1992 2014 +1.10% BenchmarkDecompress4XTable/pngdata.001-32 75929 79317 +4.46% BenchmarkDecompress4XTable/normcount2-32 1372 1344 -2.04% benchmark old MB/s new MB/s speedup BenchmarkDecompress1XTable/digits-32 390.08 380.98 0.98x BenchmarkDecompress1XTable/gettysburg-32 298.30 296.30 0.99x BenchmarkDecompress1XTable/twain-32 317.38 317.54 1.00x BenchmarkDecompress1XTable/low-ent.10k-32 454.29 452.34 1.00x BenchmarkDecompress1XTable/superlow-ent-10k-32 448.34 447.66 1.00x BenchmarkDecompress1XTable/crash2-32 21.84 22.19 1.02x BenchmarkDecompress1XTable/endzerobits-32 61.81 63.77 1.03x BenchmarkDecompress1XTable/endnonzero-32 14.17 13.71 0.97x BenchmarkDecompress1XTable/case1-32 28.23 28.59 1.01x BenchmarkDecompress1XTable/case2-32 23.49 23.86 1.02x BenchmarkDecompress1XTable/case3-32 24.67 24.99 1.01x BenchmarkDecompress1XTable/pngdata.001-32 403.44 406.84 1.01x BenchmarkDecompress1XTable/normcount2-32 67.71 67.18 0.99x BenchmarkDecompress1XNoTable/digits-32 391.40 382.14 0.98x BenchmarkDecompress1XNoTable/gettysburg-32 384.26 385.65 1.00x BenchmarkDecompress1XNoTable/twain-32 318.25 319.20 1.00x BenchmarkDecompress1XNoTable/low-ent.10k-32 459.65 458.81 1.00x BenchmarkDecompress1XNoTable/superlow-ent-10k-32 460.29 449.62 0.98x BenchmarkDecompress1XNoTable/crash2-32 181.62 223.18 1.23x BenchmarkDecompress1XNoTable/endzerobits-32 92.04 114.29 1.24x BenchmarkDecompress1XNoTable/endnonzero-32 117.43 150.28 1.28x BenchmarkDecompress1XNoTable/case1-32 307.35 346.21 1.13x BenchmarkDecompress1XNoTable/case2-32 313.02 350.41 1.12x BenchmarkDecompress1XNoTable/case3-32 290.54 331.28 1.14x BenchmarkDecompress1XNoTable/pngdata.001-32 413.79 415.26 1.00x BenchmarkDecompress1XNoTable/normcount2-32 350.06 361.51 1.03x BenchmarkDecompress4XNoTable/digits-32 654.42 659.47 1.01x BenchmarkDecompress4XNoTable/gettysburg-32 598.78 570.81 0.95x BenchmarkDecompress4XNoTable/twain-32 494.67 476.38 0.96x BenchmarkDecompress4XNoTable/low-ent.10k-32 746.25 759.53 1.02x BenchmarkDecompress4XNoTable/superlow-ent-10k-32 730.46 747.10 1.02x BenchmarkDecompress4XNoTable/case1-32 216.72 243.09 1.12x BenchmarkDecompress4XNoTable/case2-32 217.24 247.59 1.14x BenchmarkDecompress4XNoTable/case3-32 223.64 257.53 1.15x BenchmarkDecompress4XNoTable/pngdata.001-32 701.07 673.09 0.96x BenchmarkDecompress4XNoTable/normcount2-32 281.26 310.40 1.10x BenchmarkDecompress4XNoTableTableLog8/digits-32 656.59 666.15 1.01x BenchmarkDecompress4XTable/digits-32 654.50 664.02 1.01x BenchmarkDecompress4XTable/gettysburg-32 400.94 394.53 0.98x BenchmarkDecompress4XTable/twain-32 488.67 475.79 0.97x BenchmarkDecompress4XTable/low-ent.10k-32 734.42 752.22 1.02x BenchmarkDecompress4XTable/superlow-ent-10k-32 704.50 715.40 1.02x BenchmarkDecompress4XTable/case1-32 27.51 27.41 1.00x BenchmarkDecompress4XTable/case2-32 22.71 22.87 1.01x BenchmarkDecompress4XTable/case3-32 24.09 23.84 0.99x BenchmarkDecompress4XTable/pngdata.001-32 674.31 645.51 0.96x BenchmarkDecompress4XTable/normcount2-32 63.43 64.73 1.02x ```
klauspost
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make buffers safe from concurrent decoder use.