Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s2: Improve "better" compression. #635

Merged
merged 12 commits into from
Sep 8, 2022
Merged

s2: Improve "better" compression. #635

merged 12 commits into from
Sep 8, 2022

Conversation

klauspost
Copy link
Owner

@klauspost klauspost commented Jun 30, 2022

Extend long hash table to 17 bits and do intermediate hashing on matches.

Improves better compression, with minor speed drop.

Improves compression ~0.1% at ~10% speed cost. Seems too little to keep.

More benchmarking needed.
Use bigger long match table and check candidates at different lengths.
(asm missing)
@klauspost klauspost changed the title S2 better hash between S2 better hash between matches Jun 30, 2022
@klauspost klauspost marked this pull request as ready for review September 8, 2022 14:48
@klauspost klauspost changed the title S2 better hash between matches s2: Improve "better" compression. Sep 8, 2022
@klauspost klauspost merged commit 49d8cf2 into master Sep 8, 2022
@klauspost klauspost deleted the s2-better-hash-between branch September 8, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant