Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix preload timeout #273

Merged
merged 6 commits into from
Feb 13, 2025
Merged

fix preload timeout #273

merged 6 commits into from
Feb 13, 2025

Conversation

ab1470
Copy link
Contributor

@ab1470 ab1470 commented Feb 12, 2025

Description

This PR fixes an issue where the preloading timeout wasn't working on the IAFWebViewModel

Check List

  • Are you changing anything with the public API?
  • Have you tested this change on real device?
  • Are your changes backwards compatible with previous SDK Versions?
  • Have you added unit test coverage for your changes?
  • Have you verified that your changes are compatible with all the operating system version this SDK currently supports?

Manual Test Plan

  1. I manually simulated both a timeout and a successful formWillAppear event and validated that the code works as expected in both cases

@ab1470 ab1470 force-pushed the ab/fix-preload-timeout/option1 branch from 2d0107c to 96d37ce Compare February 12, 2025 19:53
@ab1470 ab1470 marked this pull request as ready for review February 12, 2025 19:58
@ab1470 ab1470 requested a review from a team as a code owner February 12, 2025 19:58
belleklaviyo
belleklaviyo approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@belleklaviyo belleklaviyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice thanks for fixing this!

@ab1470 ab1470 merged commit 0a7b349 into master Feb 13, 2025
14 checks passed
@ab1470 ab1470 deleted the ab/fix-preload-timeout/option1 branch February 13, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajaysubra ajaysubra ajaysubra approved these changes

@belleklaviyo belleklaviyo belleklaviyo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ab1470 @ajaysubra @belleklaviyo