ReferenceImagePanel renamed to ReferenceImageOptions

kleber-swf · Dec 10, 2021 · f4410f8 · f4410f8
1 parent 09c6474
commit f4410f8
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 12 deletions.
diff --git a/example/game.js b/example/game.js
@@ -39,8 +39,7 @@ function create() {
 		referenceImageUrl(width, height) {
 			return width > height
 				? './refs/ref_landscape.jpg'
-				// : './refs/ref_portrait.jpg';
-				: null;
+				: './refs/ref_portrait.jpg';
 		},
 	}));
 

diff --git a/src/core/reference-image.controller.ts b/src/core/reference-image.controller.ts
@@ -1,4 +1,4 @@
-import { ReferenceImagePanel } from 'editor-view/actions/reference-image/reference-image.panel';
+import { ReferenceImageOptions } from 'editor-view/actions/reference-image/reference-image.options';
 import { PluginConfig, Size } from 'plugin.model';
 import { ReferenceImage } from 'scene-view/reference-image/reference-image';
 import { Preferences } from './preferences/preferences';
@@ -30,7 +30,7 @@ export class ReferenceImageController {
 	}
 
 	public openOptionsPanel(opener: HTMLElement) {
-		const p = (document.createElement(ReferenceImagePanel.tagName) as ReferenceImagePanel);
+		const p = (document.createElement(ReferenceImageOptions.tagName) as ReferenceImageOptions);
 		p.openPopup('Reference Image Options', opener, this.image);
 		p.addEventListener('closed', () => this.prefs.set('referenceImageFilters', this.image.getFilters()));
 	}

diff --git a/...eference-image/reference-image.panel.scss → ...erence-image/reference-image.options.scss b/...eference-image/reference-image.panel.scss → ...erence-image/reference-image.options.scss
diff --git a/.../reference-image/reference-image.panel.ts → ...eference-image/reference-image.options.ts b/.../reference-image/reference-image.panel.ts → ...eference-image/reference-image.options.ts
@@ -1,8 +1,8 @@
 import { PopupContainer } from 'editor-view/popup/popup-container';
 import { ReferenceImage, RefImageFilterTypes } from 'scene-view/reference-image/reference-image';
-import './reference-image.panel.scss';
+import './reference-image.options.scss';
 
-export class ReferenceImagePanel extends PopupContainer {
+export class ReferenceImageOptions extends PopupContainer {
 	public static readonly tagName = 'phred-reference-image-panel';
 
 	private image: ReferenceImage;
@@ -55,4 +55,4 @@ export class ReferenceImagePanel extends PopupContainer {
 	}
 }
 
-customElements.define(ReferenceImagePanel.tagName, ReferenceImagePanel);
+customElements.define(ReferenceImageOptions.tagName, ReferenceImageOptions);
diff --git a/src/editor-view/actions/size-templates/size-templates-panel.ts b/src/editor-view/actions/size-templates/size-templates-panel.ts
@@ -50,13 +50,12 @@ export class SizeTemplatesPanel extends HTMLElement {
 
 	public setResponsiveSizeTemplate(index: number, width: number, height: number) {
 		const prefs = Editor.prefs;
-
 		const currentSize = prefs.get('responsiveSize') as Size;
 
-		width = width ?? currentSize.width ?? Preferences.DefaultResponsiveSize.width;
-		height = height ?? currentSize.height ?? Preferences.DefaultResponsiveSize.height;
-
-		if (currentSize.height > currentSize.width) {
+		if (!width || !height) {
+			width = currentSize.width ?? Preferences.DefaultResponsiveSize.width;
+			height = currentSize.height ?? Preferences.DefaultResponsiveSize.height;
+		} else if (currentSize.height > currentSize.width) {
 			const aux = width;
 			width = height;
 			height = aux;