Fix @Harton review

klee-contrib · Jul 25, 2017 · 54368cb · 54368cb
1 parent be33f10
commit 54368cb
Showing 1 changed file with 9 additions and 15 deletions.
diff --git a/src/components/input/select-checkbox/index.js b/src/components/input/select-checkbox/index.js
@@ -69,23 +69,17 @@ class SelectCheckbox extends Component {
      * @param  {[type]} newStatus the new status
      */
     _handleCheckboxChange(key, newStatus) {
-        const selectedValues = this.state.selectedValues;
-        if (newStatus) {
-            selectedValues.push(key);
-        } else {
-            pull(selectedValues, key);
-        }
+        const selectedValues = newStatus
+            ? this.state.selectedValues.concat([key])
+            : this.state.selectedValues.filter(elt => elt !== key);
 
-        if (this.props.onChange) {
-            if (this.props.legacyOnChange) {
-                this.props.onChange(key, newStatus);
-            } else {
-                this.props.onChange(selectedValues);
-            }
-            return;
+        if (this.props.onChange && this.props.legacyOnChange) {
+            this.props.onChange(key, newStatus);
+        } else if (this.props.onChange) {
+            this.props.onChange(selectedValues);
+        } else {
+            this.setState({ value: selectedValues });
         }
-
-        this.setState({ value: selectedValues });
     }
 
     /**