Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Advancedsearch][FacetBox] missing assignement in Initial state #1353

Closed
rodolpheV opened this issue Feb 7, 2017 · 1 comment
Closed

[Advancedsearch][FacetBox] missing assignement in Initial state #1353

rodolpheV opened this issue Feb 7, 2017 · 1 comment
Assignees
@c3dr0x @fconstantin
Labels
Bug Minor Waiting for Release
Milestone
2.2.0

Comments

@rodolpheV
Copy link
Contributor

The line: https://github.com/KleeGroup/focus-components/blob/master/src/search/facet-box/index.js#L53
should be:
openedFacetList = this._generateOpenedFacetList(this.props.facetList);
like in componentWillReceiveProps.

Consequence of this omission is that the component doesn't work if it is rendered only once.
@fconstantin fconstantin self-assigned this Apr 6, 2017
c3dr0x added a commit that referenced this issue Jun 12, 2017
@c3dr0x
[Advancedsearch][FacetBox] missing assignment in Initial state
536eb78 
Fix issue #1353
@c3dr0x c3dr0x mentioned this issue Jun 12, 2017
Merged
@JohnnP JohnnP added this to the 2.2.0 milestone Jul 7, 2017
@Hartorn
Copy link
Contributor

Hartorn commented Nov 15, 2017

Delivered in 2.2.0

@Hartorn Hartorn closed this as completed Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@c3dr0x c3dr0x

@fconstantin fconstantin

Labels
Bug Minor Waiting for Release
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
5 participants
@c3dr0x @Hartorn @fconstantin @JohnnP @rodolpheV