Fix input date issues #1368
Merged
Fix input date issues #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing dead code
…layPicker) => fix issue #1325
fconstantin
reviewed
Apr 10, 2017
src/components/input/date/index.js
Outdated
| this.props.onChange(dropDownDate.toISOString()); | ||
| // Fire onChange event, only if date if correct, or empty, if the option is activated | ||
| if (fromBlur !== true && (isCorrect || (triggerOnChangeIfEmpty && (inputDate || '').trim() === ''))) { | ||
| this.props.onChange(isCorrect ? dropDownDate.toISOString() : null); // if date is not correct, it is empty, so send null (or empty string ?) |
There was a problem hiding this comment.
No more condition on checkOnlyOnBlur ? When false, onChange should be called when fromBlur.
fconstantin
suggested changes
Apr 10, 2017
|
@fconstantin Oupsie, was tired I think. Did not see the second part of the condition |
Adding missing check when checkOnlyOnBlur is true and fromBlur is false
|
@fconstantin I think I should add also the option in accordance with both check |
|
@fconstantin Should be good |
fconstantin
approved these changes
Apr 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1357 and #1325
Still have to test in details before merging