Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popin - Close popin on Esc press #1522

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Popin - Close popin on Esc press #1522

wants to merge 2 commits into from

Conversation

bnau
Copy link
Contributor

@bnau bnau commented Nov 27, 2017

No description provided.

@bnau bnau mentioned this pull request Nov 27, 2017
Open
Hartorn
Hartorn suggested changes Nov 29, 2017
View reviewed changes
Copy link
Contributor

@Hartorn Hartorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not work with several popin stacked...

@AdrienViala AdrienViala self-requested a review October 2, 2018 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hartorn Hartorn Hartorn requested changes

@AdrienViala AdrienViala Awaiting requested review from AdrienViala

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bnau @Hartorn