HTTP cache methods #129
Open
HTTP cache methods #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
publicCache(), privateCache(), sendCacheHeaders() added noCache() refactored tests added
| */ | ||
|
|
||
| /** Public HTTP cache flag */ | ||
| const PUBLIC_CACHE = 'public_cache'; |
There was a problem hiding this comment.
The new constants should probably just be integers. They're values don't really have much significance, since they're meant to be compared as constants, so following the PHP (Java inspired) convention of simply assigning an integer value would be better suited here.
There was a problem hiding this comment.
String constant significance lies in debugging. Where string can suggest flags meaning without having to look at constant list. My mistake, I overlooked that DISPATCH constants use integers. Will cahnge to integers.
|
It looks fine to merge, but whether or not this belongs in this library (a microframework) is debatable. Up to you @Rican7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP cache API added publicCache(), privateCache(), noCache()