Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows overriding notification settings per alert #168

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

marks-sortable
Copy link

This fixes issue #76, allowing individual alerts to override some notification details (e.g. email recipient, Slack channel).

Example:

      {
        "name": "site-404s",
        "time_window": "10minute",
        "method": "maximum",
        "query": "...",
        "rules": ["warning: > 10"],
        "override": {
          "slack": {
            "channel": "#site-dev"
          },
          "smtp": {
            "to": "dev-site@example.org"
          }
        }
      }

Not all fields can be overridden, nor can all alert methods. Overrides usually don't let you change which server you're talking to, or what API key you're using. Available overrides:

cli
command
hipchat
room
http
url, params, method
slack
channel, username
smtp
sender, to
victorops
url, routing_key

This fixes issue klen#76, allowing individual alerts to override some notification details (e.g. email recipient, Slack channel).
@coveralls
Copy link

Coverage Status

Coverage decreased (-2.3%) to 62.777% when pulling dee22cf on marks-sortable:customize-alert-handlers into 63a9d00 on klen:develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants