Feat/core plurality disputekit #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y-disputekit-jaybuidl
… between Core and Dispute Kit
…kleros/kleros-v2 into feat/core-plurality-disputekit-jaybuidl
…-disputekit-jaybuidl
Rewrite of the existing automated test. Added _extraData parameter to createDispute() for possible use in future dispute kits. Some cosmetic changes.
Renamed DisputeKit --> DisputeKitClassic because it implemented the classic features of Kleros v1 Created DisputeKit as an abstraction so that KlerosCore is not concerned with the specifics of each one.
No guideline on single vs. double quotes for now.
|
Code Climate has analyzed commit cbde56a and detected 0 issues on this pull request. View more on Code Climate. |
|
Fine to start integrating with the other branches and start testing. We can iterate from there. |
Params10
pushed a commit
that referenced
this pull request
Feb 3, 2023
…buidl Feat/core plurality disputekit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of Core and DisputeKit.
Not feature complete yet.
If there is no major flaw (missing features are fine for now), the goal is to start integrating with the other components and run some basic tests, then iterate from there.