Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partial Fast Bridge #36

Merged
merged 9 commits into from
Feb 8, 2022
Merged

Partial Fast Bridge #36

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
037ac8f
refactor: combine ILxBridge to ISafeBridge
shalzz Feb 3, 2022
5e049b4
feat(fast-bridge): add and use fast bridge
shalzz Feb 4, 2022
2bc7e15
fix(gateway): fix cross-chain evidence related functions when we don'…
shalzz Feb 4, 2022
312d2a8
feat(gateway): create disputeHash on HomeGateway as well
shalzz Feb 4, 2022
dfe5ee8
fix(gateway): update relayCreateDispute
shalzz Feb 7, 2022
6981ded
refactor: chainID init
jaybuidl Feb 7, 2022
d8e4d50
feat: no use of the Safe Bridge in normal operations
jaybuidl Feb 7, 2022
1194070
feat: access control on the fast bridge sender
jaybuidl Feb 7, 2022
4adff44
refactor: minor renames
jaybuidl Feb 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions contracts/src/bridge/FastBridgeSender.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,31 +15,36 @@ import "./interfaces/IFastBridgeSender.sol";
import "./interfaces/IFastBridgeReceiver.sol";

contract FastBridgeSender is IFastBridgeSender {
ISafeBridge safebridge;
IFastBridgeReceiver fastBridgeReceiver;
ISafeBridge public safebridge;
IFastBridgeReceiver public fastBridgeReceiver;
address public fastSender;

/**
* The bridgers need to watch for these events and
* relay the messageHash on the FastBridgeReceiver.
*/
event OutboxMessage(address target, bytes32 messageHash, bytes messagePreImage);

constructor(ISafeBridge _safebridge, IFastBridgeReceiver _fastBridgeReceiver) {
constructor(
ISafeBridge _safebridge,
IFastBridgeReceiver _fastBridgeReceiver,
address _fastSender
) {
safebridge = _safebridge;
fastBridgeReceiver = _fastBridgeReceiver;
fastSender = _fastSender;
}

/**
* Sends an arbitrary message from one domain to another
* via the fast bridge mechanism
*
* TODO: probably needs some access control either on the sender side
* or the receiver side
*
* @param _receiver The L1 contract address who will receive the calldata
* @param _calldata The receiving domain encoded message data.
*/
function sendFast(address _receiver, bytes memory _calldata) external {
require(msg.sender == fastSender, "Access not allowed: Fast Sender only.");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason I didn't add this initially was to make the fast bridge app-agnostic.


// Encode the receiver address with the function signature + arguments i.e calldata
bytes memory encodedData = abi.encode(_receiver, _calldata);

Expand Down