Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(KC): phases implementation #65

Merged
merged 15 commits into from
May 27, 2022
Merged

feat(KC): phases implementation #65

merged 15 commits into from
May 27, 2022

Conversation

jaybuidl
Copy link
Member

Last PR for this :)

Resolves #26

Duplicates #64 #42

Rely more on inputs from view functions to pass the phases.
Removal of the active dispute kits state in KlerosCore.
Allow changing the dispute kit phase from Drawing to Resolving inside DK.passPhase().
For safety, DK.passPhase() can reset its phase if it ever is not Resolving when Core is Staking.
Disabled the contract size limit on the Hardhat network because it's not a limitation on Arbitrum.
Also less reliance on the bots, clearer function names.
…g a DK back to Resolving

And fixed an array element removal.
@codeclimate
Copy link

codeclimate bot commented May 27, 2022

Code Climate has analyzed commit a7d325f and detected 0 issues on this pull request.

View more on Code Climate.

@jaybuidl jaybuidl merged commit 1f37609 into master May 27, 2022
@jaybuidl jaybuidl deleted the feat/arbitration-phases branch May 27, 2022 16:40
@jaybuidl jaybuidl restored the feat/arbitration-phases branch November 24, 2022 02:59
@jaybuidl jaybuidl deleted the feat/arbitration-phases branch November 24, 2022 03:09
Params10 pushed a commit that referenced this pull request Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Phases management: state machines of DisputeKitClassic and KlerosCore
2 participants