feat: Support simple model serving #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caicloud-bot
added
release-note-none
simon-cj
changed the title
caicloud-bot
added
the
do-not-merge/work-in-progress
simon-cj
changed the title
simon-cj
force-pushed
the
master
branch
2 times, most recently
from
56eebb7 to
da62b69
Compare
caicloud-bot
added
size/XL
simon-cj
force-pushed
the
master
branch
2 times, most recently
from
c62f55a to
6ca8ec2
Compare
caicloud-bot
added
size/XXL
simon-cj
changed the title
caicloud-bot
removed
the
do-not-merge/work-in-progress
simon-cj
force-pushed
the
master
branch
5 times, most recently
from
4ec54a4 to
44f7515
Compare
|
/cc @gaocegege |
gaocegege
reviewed
Aug 28, 2020
| - name: KLEVER_MODEL_REGISTRY_PORT | ||
| value: {{ .Values.service.Port }} | ||
| - name: ORMB_DOMAIN |
There was a problem hiding this comment.
We can use ORMB_DOMAIN I think.
gaocegege
reviewed
Aug 28, 2020
pkg/registry/serving/composer.go
Outdated
| MountPath: modelMountPath, | ||
| }, | ||
| }, | ||
| ImagePullPolicy: corev1.PullAlways, |
| Args: []string{p.Graph.ModelURI, modelMountPath}, | ||
| Env: []corev1.EnvVar{ | ||
| { | ||
| Name: "AWS_ACCESS_KEY_ID", |
There was a problem hiding this comment.
Please add some comments about the KEY to let readers know why we use AWS_ACCESS_KEY_ID instead of ORMB_XXX.
gaocegege
reviewed
Aug 28, 2020
| @@ -25,7 +25,7 @@ export SHELLOPTS := errexit | |||
| ROOT := github.com/kleveross/klever-model-registry | |||
|
|
|||
| # Target binaries. You can build multiple binaries for a single project. | |||
| TARGETS := klever-model-registry klever-modeljob-operator | |||
| TARGETS := model-registry modeljob-operator | |||
There was a problem hiding this comment.
I remember that we decide to have one separate binary for inference?
There was a problem hiding this comment.
the inference binary is trtserver and openscoring jar package, not include source code.
simon-cj
force-pushed
the
master
branch
2 times, most recently
from
34d1415 to
f070591
Compare
|
comments are addressed, PTAL. thanks |
|
reviewing? can merge? |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
caicloud-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add your description
Which issue(s) this PR is related to (optional, link to 3rd issue(s)):
Fixes #
Reference to #
Special notes for your reviewer:
/cc @your-reviewer
Release note: