Fix #1054, use ColorPicker control, fix reset to defaults #1063
Conversation
Color settings were copied from PronterWindow.settings to PronterWindow before reading them from config file into PronterWindow.settings.
Now settings except 3D view move colors (e.g. gcview_color_background) are applied without restart
Reset was not detected for applying because it set both widget value and setting value. Removed confirmation message box for each reset setting and let the settings dialog OK button confirm as with normal changes
Use wxpython widget ColourPickerCtrl. Tested only on Ubuntu. Move validation callbacks from Settings.__...() to Setting.validate()
|
Tested these, everything seems to work as described, but on_settings_change crashes when 3d view is disabled. Can you investigate? Also, I have invited you to this repository as a contributor - you have been that for a long time already, and it's only fair to make it official. |
|
@kliment , thank you for the contributor privilege and the project. It's a great honor for me, I appreciate your trust. |
Extracted base class BaseViz to add structure, reuse code, and reduce hasattr()
|
@kliment , please merge this request if the problem is fixed now. |
|
It is! but something strange is still happening. When I have 2d view selected, start the program, and switch to 3d view, and load a gcode file, it does not get shown in the detailed view window (the one that shows when clicking the preview in the main window). When I switch back to 2d view, it does show in the detail view window but not in the 2d preview window. If I switch to 3d again, the main window preview is correct but the detail view is empty. Does this happen for you too? |
|
I experienced this kind of behavior, but I do not think this pull request breaks it. It is more like the PR exposes the behavior by replacing the 2D <-> 3D UI on the fly. The detail view appear empty, but if you drag the layer slider it shows layers, seems to be positioned below the first layer. |
|
When I set both views to 3d, loading a file shows it in the detailed view on master and doesn't show it in this PR. On both master and this PR it's not shown correctly in the main window, but this PR breaks it in the detailed view as well. This happens even if the settings were not changed since last restart. |
It's a regression in my recent commit.
Used _ for a dummy int variable, and _('localization') broke.
Added logging where the exception was
silently ignored
|
@kliment , yes the PR has a bug in loading for 3D view. I will commit fix tomorrow. |
|
Thanks, that fixes the regression! I've merged this into master. There is still a problem where the main 3d view is not populated if both views are set to 3D, but that bug was already present in master. Thank you! |
|
Thank you. |
|
Thank you for your work on this @volconst! |
See individual commits for more info.