Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .exe build workflow #1106

Merged
merged 3 commits into from
Sep 10, 2020
Merged

Add .exe build workflow #1106

merged 3 commits into from
Sep 10, 2020

Conversation

kliment
Copy link
Owner

@kliment kliment commented Sep 10, 2020

This automatically builds Windows executables

@hroncok
Copy link
Collaborator

hroncok commented Sep 10, 2020

The 32bit version starts on Windows 7. I don't have a printer to connect to.

_

@kliment
Copy link
Owner Author

kliment commented Sep 10, 2020

Yes, same in win64 but I can only test in virtualbox at the moment

@kliment
Copy link
Owner Author

kliment commented Sep 10, 2020

Any objections to merging this as-is @hroncok ?

@hroncok
Copy link
Collaborator

hroncok commented Sep 10, 2020

Well, this doesn't publish the exes anywhere prominent so even if they are broken, it should be good. Ship it!

@kliment kliment merged commit 9028348 into master Sep 10, 2020
@kliment
Copy link
Owner Author

kliment commented Sep 10, 2020

Shipped - the only concern I have is that it eats lots of CI minutes - and the mac one even more so (which is why it's in a separate branch). I'm thinking of making it build on release only, or somehow manually trigger

@rockstorm101 rockstorm101 deleted the build-win-exe branch January 23, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants