Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some baud rates #1267

Merged
merged 1 commit into from
Mar 27, 2023
Merged

add some baud rates #1267

merged 1 commit into from
Mar 27, 2023

Conversation

prchal
Copy link
Contributor

@prchal prchal commented Jun 10, 2022

Add some more fast baud rates.

Add some more fast baud rates.
@rockstorm101
Copy link
Collaborator

Hi @prchal, I know you proposed this a long time ago, sorry about that. I don't see those rates being "standard" baud rates? At least not for 3D printers? What is your use case such that do need these rates? It would appear 460,800 or 576,000 and 921,600 are more common than exactly 500,000 and 1,000,000?

@DivingDuck
Copy link
Collaborator

I also do not like this very well as baud rate should follow 2n bit scheme for summarized bits, but unfortunately the Marlin folks broke with this kind of conventions ...
https://github.com/MarlinFirmware/Marlin/blob/bugfix-2.1.x/Marlin/Configuration.h#L112

@prchal
Copy link
Contributor Author

prchal commented Mar 27, 2023 via email

@kliment
Copy link
Owner

kliment commented Mar 27, 2023

I agree with @prchal here - some firmwares use these baud rates for technical reasons, and whether we like it or not it's a reality and something some users need.

@rockstorm101
Copy link
Collaborator

the Marlin folks broke with this kind of conventions ...
https://github.com/MarlinFirmware/Marlin/blob/bugfix-2.1.x/Marlin/Configuration.h#L112

Oh, well spotted. Merging then.

@rockstorm101 rockstorm101 merged commit 774ea99 into kliment:master Mar 27, 2023
@prchal prchal deleted the patch-1 branch March 28, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants