Replace configparser readfp with read_file #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
readfp() was [deprecated in Python 3.2][1] and [removed in Python 3.12][2]. read_file() is a drop-in replacement. [1]: https://github.com/python/cpython/blob/dd0e8a62df8be2a09ef6035b4c92bd9a68a7b918/Lib/configparser.py#L757-L764 [2]: python/cpython@1fc41ae Fixes this error with Python 3.12: ``` Traceback (most recent call last): File "/usr/bin/pronterface.py", line 62, in <module> app = PronterApp(False) ^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.12/site-packages/printrun/pronterface.py", line 2596, in __init__ self.mainwindow = PronterWindow(self) ^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.12/site-packages/printrun/pronterface.py", line 220, in __init__ self.reload_ui() File "/usr/lib/python3.12/site-packages/printrun/pronterface.py", line 288, in reload_ui self.create_menu() File "/usr/lib/python3.12/site-packages/printrun/pronterface.py", line 862, in create_menu self.load_slic3r_configs(menus) File "/usr/lib/python3.12/site-packages/printrun/pronterface.py", line 2517, in load_slic3r_configs config = self.read_slic3r_config(configfile) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.12/site-packages/printrun/pronterface.py", line 2562, in read_slic3r_config parser.readfp(add_header(open(configfile)), configfile) ^^^^^^^^^^^^^ AttributeError: 'RawConfigParser' object has no attribute 'readfp'. Did you mean: 'read'? ```
|
Nice finding and yes, we should change this. Btw , we actually do not support Python 3.12, @rockstorm101, I did a successful quick test locally for Windows with py3.10 |
|
Very good report with helpful and on-point links. Many thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readfp() was deprecated in Python 3.2 and removed in Python 3.12. read_file() is a drop-in replacement.
Fixes this error with Python 3.12: