-
Notifications
You must be signed in to change notification settings - Fork 999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a wrapper around pySerial to monkey patch support for custom baudrates #712
Conversation
Wouldn't changing the requirements.txt to |
I hadn't noticed there's a requirements.txt file, but yes, changing the requirements there would be good, but this patch is meant to make printrun work with pyserial 2.6, not change its requirements to 2.7. |
The license on this is problematic - Printrun is GPLv3 whereas this is AGPLv3. @kakaroto, if you're the author of this, would you be willing to change the license? Essentially all the code appears to be a straight copy from pyserial anyway. |
…rates This is only useful if the pyserial version installed is lower than 2.7 since that doesn't support custom baudrates such as 250000.
POSIX includes OS X, which does not need to use this patch
@kliment, thanks for looking into this. I've updated the code with a couple of fixes and changed the license to match the pyserial license. For your information, pyserial 2.7 was Thanks! |
Revert PR #712 "Add a wrapper around pySerial"
This is only useful if the pyserial version installed is lower than 2.7 since that doesn't support custom baudrates on linux.
The monkey patch will replace the set_special_baudrates function in the serial module with the version of the function from pyserial 2.7 which allows the use of 250000 baudrates on Linux. If pyserial is 2.7 or newer, it won't do anything.