Merge pull request vimeo#10883 from gsteel/strnatcasecmp

Update PHP 8.2 Call map delta with refined types for string comparison functions
klimick · May 1, 2024 · 462c80e · 462c80e
2 parents c631102 + 7587749
commit 462c80e
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 6 deletions.
diff --git a/dictionaries/CallMap.php b/dictionaries/CallMap.php
@@ -12825,9 +12825,9 @@
 'str_split' => ['list<non-empty-string>', 'string'=>'string', 'length='=>'positive-int'],
 'str_starts_with' => ['bool', 'haystack'=>'string', 'needle'=>'string'],
 'str_word_count' => ['array<int, string>|int', 'string'=>'string', 'format='=>'int', 'characters='=>'?string'],
-'strcasecmp' => ['int', 'string1'=>'string', 'string2'=>'string'],
+'strcasecmp' => ['int<-1,1>', 'string1'=>'string', 'string2'=>'string'],
 'strchr' => ['string|false', 'haystack'=>'string', 'needle'=>'string', 'before_needle='=>'bool'],
-'strcmp' => ['int', 'string1'=>'string', 'string2'=>'string'],
+'strcmp' => ['int<-1,1>', 'string1'=>'string', 'string2'=>'string'],
 'strcoll' => ['int', 'string1'=>'string', 'string2'=>'string'],
 'strcspn' => ['int', 'string'=>'string', 'characters'=>'string', 'offset='=>'int', 'length='=>'?int'],
 'stream_bucket_append' => ['void', 'brigade'=>'resource', 'bucket'=>'object'],
@@ -12910,10 +12910,10 @@
 'stripslashes' => ['string', 'string'=>'string'],
 'stristr' => ['string|false', 'haystack'=>'string', 'needle'=>'string', 'before_needle='=>'bool'],
 'strlen' => ['0|positive-int', 'string'=>'string'],
-'strnatcasecmp' => ['int', 'string1'=>'string', 'string2'=>'string'],
-'strnatcmp' => ['int', 'string1'=>'string', 'string2'=>'string'],
-'strncasecmp' => ['int', 'string1'=>'string', 'string2'=>'string', 'length'=>'int'],
-'strncmp' => ['int', 'string1'=>'string', 'string2'=>'string', 'length'=>'int'],
+'strnatcasecmp' => ['int<-1,1>', 'string1'=>'string', 'string2'=>'string'],
+'strnatcmp' => ['int<-1,1>', 'string1'=>'string', 'string2'=>'string'],
+'strncasecmp' => ['int<-1,1>', 'string1'=>'string', 'string2'=>'string', 'length'=>'positive-int|0'],
+'strncmp' => ['int<-1,1>', 'string1'=>'string', 'string2'=>'string', 'length'=>'positive-int|0'],
 'strpbrk' => ['string|false', 'string'=>'string', 'characters'=>'string'],
 'strpos' => ['int|false', 'haystack'=>'string', 'needle'=>'string', 'offset='=>'int'],
 'strptime' => ['array|false', 'timestamp'=>'string', 'format'=>'string'],

diff --git a/dictionaries/CallMap_82_delta.php b/dictionaries/CallMap_82_delta.php
@@ -57,6 +57,30 @@
         'old' => ['array|string|int|false', 'type='=>'string'],
         'new' => ['array|string|int|false|null', 'type='=>'string'],
     ],
+    'strcmp' => [
+        'old' => ['int', 'string1' => 'string', 'string2' => 'string'],
+        'new' => ['int<-1,1>', 'string1' => 'string', 'string2' => 'string'],
+    ],
+    'strcasecmp' => [
+        'old' => ['int', 'string1' => 'string', 'string2' => 'string'],
+        'new' => ['int<-1,1>', 'string1' => 'string', 'string2' => 'string'],
+    ],
+    'strnatcasecmp' => [
+        'old' => ['int', 'string1' => 'string', 'string2' => 'string'],
+        'new' => ['int<-1,1>', 'string1' => 'string', 'string2' => 'string'],
+    ],
+    'strnatcmp' => [
+        'old' => ['int', 'string1' => 'string', 'string2' => 'string'],
+        'new' => ['int<-1,1>', 'string1' => 'string', 'string2' => 'string'],
+    ],
+    'strncmp' => [
+        'old' => ['int', 'string1'=>'string', 'string2'=>'string', 'length'=>'int'],
+        'new' => ['int<-1,1>', 'string1' => 'string', 'string2' => 'string', 'length'=>'positive-int|0'],
+    ],
+    'strncasecmp' => [
+        'old' => ['int', 'string1'=>'string', 'string2'=>'string', 'length'=>'int'],
+        'new' => ['int<-1,1>', 'string1' => 'string', 'string2' => 'string', 'length'=>'positive-int|0'],
+    ],
   ],
 
   'removed' => [