Merge pull request #314 from kmcwebdev/development

Fix variable assignment and remove unnecessary comment
kmcwebdev · Oct 9, 2023 · 8f51e8f · 8f51e8f
2 parents b620431 + 457aa0f
commit 8f51e8f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/src/finance/services/reimbursement.analytics.service.ts b/src/finance/services/reimbursement.analytics.service.ts
@@ -7,7 +7,6 @@ import {
   CANCELLED_REQUEST,
   ONHOLD_REQUEST,
   PENDING_REQUEST,
-  PROCESSING_REQUEST,
   REJECTED_REQUEST,
   SCHEDULED_REQUEST,
   UNSCHEDULED_REQUEST,
@@ -370,8 +369,8 @@ export class ReimbursementAnalyticsService {
           )
           .where(
             'finance_reimbursement_requests.finance_request_status_id',
-            '!=',
-            PROCESSING_REQUEST,
+            '=',
+            PENDING_REQUEST,
           )
           .executeTakeFirst();
 
@@ -390,8 +389,8 @@ export class ReimbursementAnalyticsService {
           )
           .where(
             'finance_reimbursement_requests.finance_request_status_id',
-            '!=',
-            PROCESSING_REQUEST,
+            '=',
+            PENDING_REQUEST,
           )
           .where(
             'finance_reimbursement_requests.reimbursement_request_type_id',
@@ -415,8 +414,8 @@ export class ReimbursementAnalyticsService {
           )
           .where(
             'finance_reimbursement_requests.finance_request_status_id',
-            '!=',
-            PROCESSING_REQUEST,
+            '=',
+            PENDING_REQUEST,
           )
           .where(
             'finance_reimbursement_requests.reimbursement_request_type_id',

diff --git a/src/users/services/users.api.service.ts b/src/users/services/users.api.service.ts
@@ -133,7 +133,7 @@ export class UsersApiService {
       password: temporaryPassword,
       askUserToUpdatePasswordOnLogin: true,
       sendEmailToConfirmEmailAddress: false,
-      emailConfirmed: true, // TODO: Might be a dangerous move.
+      emailConfirmed: true,
     });
 
     this.eventEmitter.emit('reimbursement-request-send-email-new-user', {