Update propelauth_user_id with propelauthUser.userId if propelauthUse…

…r exists
kmcwebdev · Sep 29, 2023 · a0f67c7 · a0f67c7
1 parent 6df14f5
commit a0f67c7
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/users/services/cron/user-update.cron.service.ts b/src/users/services/cron/user-update.cron.service.ts
@@ -40,7 +40,7 @@ export class UserUpdateCronService {
           u.email,
         );
 
-        if (userInErpHrV1.status === 200) {
+        if (userInErpHrV1.status === 200 && propelauthUser) {
           const {
             sr,
             name,
@@ -55,7 +55,7 @@ export class UserUpdateCronService {
           const updatedUser = await this.pgsql
             .updateTable('users')
             .set({
-              propelauth_user_id: propelauthUser ? propelauthUser.userId : null,
+              propelauth_user_id: propelauthUser.userId,
               employee_id: sr || 'Not set in erp hr',
               full_name: name,
               first_name: firstName,
@@ -67,6 +67,7 @@ export class UserUpdateCronService {
                   ? TEMPORARY_APPROVER
                   : hrbpEmail,
               position,
+              temporary_propelauth_user_id: false,
               updated_via_cron_erp_hr: true,
             })
             .returning(['users.email'])