Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve playback control button affordance #119

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jacobpgn
Copy link

@jacobpgn jacobpgn commented Apr 8, 2018

For #12

This adds:

  • button alpha change on hover state
  • more recognisable next/previous icons
  • smaller target areas to make it harder to hit the wrong button

kapture 2018-04-08 at 1 08 33

For kmikiy#12

This adds:
- button alpha change on hover state
- more recognisable next/previous icons
- smaller target areas to make it harder to hit the wrong button
@jacobpgn
Copy link
Author

jacobpgn commented Apr 8, 2018

My first time using Xcode and Swift, so I apologise in advance if I've done anything weird here!

@kmikiy
Copy link
Owner

kmikiy commented Apr 8, 2018

Thanks for the PR 👌🏻I'll check it as soon as i can

- larger next and previous buttons
@kmikiy
Copy link
Owner

kmikiy commented Apr 9, 2018

I've updated the size of the next and previous buttons and added a more subtle pressed in state (.leftMouseDown). What do you think?

so I apologise in advance if I've done anything weird here!

No worries. Nothing weird. By the way this whole project could use some refactoring 😬

@jacobpgn
Copy link
Author

Pressed in state looks much better now, nice one!

I think the previous button is positioned a few points too high, are you seeing that too?

@kmikiy
Copy link
Owner

kmikiy commented Apr 10, 2018

I think the previous button is positioned a few points too high, are you seeing that too?

Could be. The auto guidelines in xcode kept snapping the buttons in position.

I also noticed that the pause icon is a bit fuzzy on the top left and bottom right. I haven’t looked in to why that’s happening. Maybe due to the resolution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants