Skip to content

Commit

Permalink
ci: re-enable sort.py
Browse files Browse the repository at this point in the history
It was disabled on commit df6ea88 ("merges, disable sort.py in profile
checks temporarely, two more private-etc profiles", 2023-02-14).

Currently all profiles are sorted and there are no ongoing `private-etc`
changes, so it should be safe to re-enable.

Note that the script is useful to catch sorting issues not only in
`private-etc` but also in other commands, such as `seccomp`[1] [2].

This is a follow-up to netblue30#6070.

Relates to netblue30#5610.

[1] netblue30#6066 (comment)
[2] netblue30#6067 (comment)
  • Loading branch information
kmk3 committed Nov 26, 2023
1 parent 7d05a6a commit 78bbcb7
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/check-profiles.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@ jobs:
run: ./ci/printenv.sh
- run: python3 --version

# - name: sort.py
# run: >
# ./ci/check/profiles/sort.py
# etc/inc/*.inc etc/{profile-a-l,profile-m-z}/*.profile
- name: sort.py
run: >
./ci/check/profiles/sort.py
etc/inc/*.inc etc/{profile-a-l,profile-m-z}/*.profile
# Currently broken (see #5610)
# - name: private-etc-always-required.sh
# run: >
Expand Down

0 comments on commit 78bbcb7

Please sign in to comment.