Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added feature for listing holidays for the running month (statewise for India) #86

Open
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

siddhant-nair
Copy link

@siddhant-nair siddhant-nair commented Jan 7, 2025

  • Added Holiday feature.
  • You can check holidays in your state for the current month
  • Data is fetched from a local json created for 2025

For today's date:
Screenshot from 2025-01-07 12-31-22

For a future date:
Screenshot from 2025-05-07 12-28-52

@siddhant-nair siddhant-nair marked this pull request as ready for review January 7, 2025 07:14
@knadh
Copy link
Owner

knadh commented Jan 13, 2025

This is nice. Let's add country-code suffix support and make it univeral. Eg: kerala.holidays.in or holidays.us etc.

  • Query comes in as *.holiday.$code or .holidays.$code
  • Refactor the internal map to [$code][state]
  • Files in the data dir can be holidays.$code.json

@siddhant-nair
Copy link
Author

Was adding country support and figured I might as well add TLD support in general

  • Added a new function in handlers called registerWithTLDSupport
  • Added holidays of 10 countries!
  • if state name is not mentioned only the national holidays are displayed

@knadh
Copy link
Owner

knadh commented Jan 20, 2025

This is great! If you can fix the merge conflict, we can merge and take this live.

@siddhant-nair
Copy link
Author

All done!

You might want to check the config once though.
The nanoid limits in the main.go file (nanoid.max_results & nanoid.max_length) are missing

@knadh
Copy link
Owner

knadh commented Jan 21, 2025

Cheers. Will test and merge it this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants