Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use inbuilt frontend dev server to proxy API instead of Nginx #199

Merged
merged 1 commit into from
Oct 4, 2020

Conversation

vividvilla
Copy link
Collaborator

@vividvilla vividvilla commented Oct 2, 2020

Vue's inbuilt dev server can be configured to proxy API for development instead of directing developers to setup Nginx proxy. Additionally, this MR also adds the option to configure the frontend port on which dev server runs. Sample env config file is under frontend/.env.sample, it can be copied to either frontend/.env or frontend/.env.local.

Available options are

LISTMONK_FRONTEND_PORT - Configure frontend dev server port (defaults to 8080)
LISTMONK_API_URL - Configure API server URL (defaults to http://127.0.0.1:9000)

Since env variables are sourced to the current session we are prefixing it with LISTMONK_.

@vividvilla vividvilla requested a review from knadh October 2, 2020 23:18
Vue's inbuilt dev server can be configured to proxy API for
development instead of directing developers to setup Nginx proxy.
Additionally this commit also adds an option to configure frontend port
on which dev server runs. Sample env config file is under
`frontend/.env.sample`, it can be copied to either `frontend/.env` or `frontend/.env.local`.

Available options are

LISTMONK_FRONTEND_PORT - Configure frontend dev server port (defaults to 8080)
LISTMONK_API_URL - Configure API server URL (defaults to http://127.0.0.1:9000)

Since env variables are sourced to current session we are prefixing it with `LISTMONK_`.
@knadh knadh merged commit 03338d5 into master Oct 4, 2020
@vividvilla vividvilla deleted the feat-inbuilt-dev-server branch October 4, 2020 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants