Adding integration with the kn/pkg schema cli for the Discovery repo.

[n3wscott]

Changes

• 🎁 Add schema defintion to the clusterducktype

/kind documentation

Before:

(╯°□°)╯︵  kubectl explain ClusterDuckType
KIND:     ClusterDuckType
VERSION:  discovery.knative.dev/v1alpha1

DESCRIPTION:
     <empty>

After:

(╯°□°)╯︵  kubectl explain ClusterDuckType
KIND:     ClusterDuckType
VERSION:  discovery.knative.dev/v1alpha1

DESCRIPTION:
     <empty>

FIELDS:
   apiVersion	<string>
     APIVersion defines the versioned schema of this representation of an
     object. Servers should convert recognized schemas to the latest internal
     value, and may reject unrecognized values. More info:
     https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources

   kind	<string>
     Kind is a string value representing the REST resource this object
     represents. Servers may infer this from the endpoint the client submits
     requests to. Cannot be updated. In CamelCase. More info:
     https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds

   metadata	<Object>
     Standard object's metadata. More info:
     https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata

   spec	<Object>
     Spec holds the desired state of the ClusterDuckType (from the client).

   status	<Object>
     Status communicates the observed state of the ClusterDuckType (from the
     controller).

Or more detail:

(╯°□°)╯︵  kubectl explain ClusterDuckType.spec
KIND:     ClusterDuckType
VERSION:  discovery.knative.dev/v1alpha1

RESOURCE: spec <Object>

DESCRIPTION:
     Spec holds the desired state of the ClusterDuckType (from the client).

FIELDS:
   group	<string>
     Group is the API group of the defined duck type. Must match the name of the
     ClusterDuckType (in the form `<names.plural>.<group>`).

   names	<Object>
     Names holds the naming conventions for this duck type.

   selectors	<[]map[string]>
     Selectors is a list of selectors for CustomResourceDefinitions to identify
     a duck type.

   versions	<[]map[string]>
     Versions holds the schema and printer column mappings for specific versions
     for duck types.

Etc...

Integration steps

go run ./cmd/schema/ dump ClusterDuckType | pbcopy

Paste this inside the CRD (config/300-clusterducktype.yaml) for ClusterDuckType:

...
      schema:
        openAPIV3Schema:
          <**paste**>
      additionalPrinterColumns:
...

Release Note

ClusterDuckType now supports kubectl describe.

[knative-prow-robot]

@n3wscott: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them

In response to this:

Changes

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knative-prow-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[codecov]

Codecov Report

Merging #153 (ef6f8bf) into main (2e19b85) will increase coverage by 0.36%.
The diff coverage is n/a.

❗ Current head ef6f8bf differs from pull request most recent head 2b595dc. Consider uploading reports for the commit 2b595dc to get more accurate results

@@            Coverage Diff             @@
##             main     #153      +/-   ##
==========================================
+ Coverage   88.92%   89.29%   +0.36%     
==========================================
  Files          10       10              
  Lines         271      271              
==========================================
+ Hits          241      242       +1     
+ Misses         23       22       -1     
  Partials        7        7              

Impacted Files	Coverage Δ
...g/apis/discovery/v1alpha1/clusterducktype_types.go	100.00% <ø> (ø)
pkg/collection/duck_sort.go	100.00% <0.00%> (+20.00%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e19b85...2b595dc. Read the comment docs.

[n3wscott]

/retry

[vaikas]

/lgtm
/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vaikas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment