Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OIDC Identity Creation in Triggers #3378

Closed
Cali0707 opened this issue Oct 4, 2023 · 4 comments
Closed

Support OIDC Identity Creation in Triggers #3378

Cali0707 opened this issue Oct 4, 2023 · 4 comments
Assignees

Comments

@Cali0707
Copy link
Member

Cali0707 commented Oct 4, 2023

Problem
Currently, the trigger in EKB does not support OIDC Identity Creation. We should add this support.

Persona:
Which persona is this feature for?

Exit Criteria
A unit test for the trigger verifying that trigger.Status.OIDCIdentityCreated = true

Time Estimate (optional):
How many developer-days do you think this may take to resolve? 1

Additional context (optional)
Add any other context about the feature request here.

@Cali0707
Copy link
Member Author

Cali0707 commented Oct 4, 2023

cc @creydr

@karkabbage
Copy link
Contributor

/assign

@Cali0707
Copy link
Member Author

Cali0707 commented Nov 13, 2023

@karkabbage this reference PR from where the same changes were made in eventing core might be helpful: knative/eventing#7299

Please note that a lot of the changes there are already included in eventing kafka broker (such as all of the new functions in trigger_lifecycle.go, so you won't have to re-implement that part. The main changes you will have to make will be in trigger.go and controller.go in control-plane/pkg/reconciler/trigger, as well as updating the associated unit tests (in trigger_test.go and controller_test.go)

If you have any questions, don't hesitate to ping me!

@creydr
Copy link
Contributor

creydr commented Jan 31, 2024

I oversaw/didn't remember this, when I created #3521 and added it to the OIDC project.
Will close this, as the other has already a PR open.
Sorry for the confusion

@creydr creydr closed this as not planned Won't fix, can't repro, duplicate, stale Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants