Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger create and expose OIDC service account #7299

Merged
merged 6 commits into from
Sep 28, 2023

Conversation

creydr
Copy link
Member

@creydr creydr commented Sep 26, 2023

Fixes #7222

Proposed Changes

  • 🎁 Expose the name of the OIDC service account in the Triggers .status.auth.serviceAccountName
  • 🎁 Create the OIDC service account of the Trigger

Release Note

Expose the Triggers OIDC service account name in the Triggers .status.auth.serviceAccountName

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 26, 2023
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2023
@creydr
Copy link
Member Author

creydr commented Sep 26, 2023

/hold
until #7173 is fixed and we can rebase (d678c3d can be removed then)

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (ff9444d) 77.66% compared to head (8941b64) 77.54%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7299      +/-   ##
==========================================
- Coverage   77.66%   77.54%   -0.13%     
==========================================
  Files         250      250              
  Lines       13436    13491      +55     
==========================================
+ Hits        10435    10461      +26     
- Misses       2478     2506      +28     
- Partials      523      524       +1     
Files Coverage Δ
pkg/apis/duck/v1/subscribable_types.go 100.00% <ø> (ø)
pkg/apis/eventing/v1/trigger_types.go 100.00% <ø> (ø)
pkg/apis/flows/v1/parallel_types.go 100.00% <ø> (ø)
pkg/apis/flows/v1/sequence_types.go 100.00% <ø> (ø)
pkg/apis/messaging/v1/subscription_types.go 66.66% <ø> (ø)
pkg/reconciler/broker/trigger/controller.go 93.90% <100.00%> (+0.75%) ⬆️
pkg/reconciler/broker/trigger/trigger.go 83.78% <100.00%> (+1.06%) ⬆️
pkg/apis/eventing/v1/trigger_lifecycle.go 51.00% <50.00%> (-0.09%) ⬇️
pkg/auth/serviceaccount.go 52.17% <4.34%> (-47.83%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@creydr creydr changed the title [WIP] Trigger create and expose OIDC service account Trigger create and expose OIDC service account Sep 27, 2023
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 27, 2023
@creydr
Copy link
Member Author

creydr commented Sep 27, 2023

rebased as #7173 is done
/unhold

@pierDipi could you check on this?

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 27, 2023
@pierDipi pierDipi self-requested a review September 27, 2023 15:12
@creydr
Copy link
Member Author

creydr commented Sep 27, 2023

@pierDipi since we have a new status condition, we need to update the other broker implementations too (at least the tests). We will probably need to do that for the other resources (e.g. Subscriptions) too :/

@creydr
Copy link
Member Author

creydr commented Sep 27, 2023

/retest

pkg/auth/serviceaccount.go Outdated Show resolved Hide resolved
pkg/reconciler/broker/trigger/trigger.go Outdated Show resolved Hide resolved
pkg/auth/serviceaccount.go Outdated Show resolved Hide resolved
pkg/auth/serviceaccount.go Outdated Show resolved Hide resolved
pkg/apis/eventing/v1/trigger_lifecycle.go Outdated Show resolved Hide resolved
Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2023
@knative-prow
Copy link

knative-prow bot commented Sep 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support auto generation of Triggers identity service account and expose in AuthStatus
2 participants