Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support auto generation of SinkBindings identity service account and expose in AuthStatus #7324

Closed
creydr opened this issue Sep 29, 2023 · 4 comments · Fixed by #7327
Closed
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@creydr
Copy link
Member

creydr commented Sep 29, 2023

Problem

As the Eventing OIDC feature track describes, the AuthStatus is meant to provide the generated service account name in the resource status.

After #7173 is done, we should:

@creydr creydr added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Sep 29, 2023
@creydr
Copy link
Member Author

creydr commented Sep 29, 2023

#7299 and #7316 show how this was done for the Trigger and could help to get started with this.

@rahulii
Copy link
Contributor

rahulii commented Sep 29, 2023

/assign

@rahulii
Copy link
Contributor

rahulii commented Sep 30, 2023

hey @creydr , I suppose this is the right place to add the code - https://github.com/knative/eventing/blob/main/pkg/reconciler/sinkbinding/controller.go
please correct me If I am wrong ?

@creydr
Copy link
Member Author

creydr commented Oct 2, 2023

hey @creydr , I suppose this is the right place to add the code - https://github.com/knative/eventing/blob/main/pkg/reconciler/sinkbinding/controller.go please correct me If I am wrong ?

Hello @rahulii,
Thanks for working on this 👍
Yes, the given link points to the SinkBinding controller.
The SinkBinding controller is a bit special compared to the other controllers, as it uses under the hood the podspecable bindings reconciler (README.md). So the reconciler which is important for you is the SinkBindingSubResourceReconciler.

Does this help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants